Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "infer auth method without request" #897

Merged
merged 1 commit into from
Aug 29, 2024

Conversation

esolitos
Copy link
Contributor

@esolitos esolitos commented Aug 29, 2024

What

Reverts #894

Why

We noticed some issues on authenticating with mtls to recently deployed applications on this version.
Still not sure if this is a real issue, as it was observed locally, but not in integration tests, or Colab.

@esolitos esolitos marked this pull request as ready for review August 29, 2024 09:48
Copy link
Collaborator

@thomasht86 thomasht86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏

@thomasht86 thomasht86 merged commit 527eeed into master Aug 29, 2024
42 checks passed
@thomasht86 thomasht86 deleted the revert-894-thomasht86/move-get_valid_authmethods branch August 29, 2024 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants